Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI issue occurring while opening assignee modal #250

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

ayusht2810
Copy link
Contributor

Summary

Fixed UI issue occurring while opening assignee modal

Ticket Link

Fixes #218

Screenshot

image

Checklist

  • Completed dev testing
  • make test Ran test cases and ensured they are passing
  • make check-style Ran style check and ensured both webapp and server pass the checks

@ayusht2810 ayusht2810 requested a review from mickmister as a code owner April 12, 2024 09:12
@ayusht2810 ayusht2810 self-assigned this Apr 12, 2024
@ayusht2810 ayusht2810 added the 2: Dev Review Requires review by a core committer label Apr 12, 2024
@mickmister
Copy link
Contributor

/update-branch

@mickmister mickmister added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Apr 23, 2024
@mickmister
Copy link
Contributor

@ayusht2810 Updating the branch with master should fix any playwright CI errors

@AayushChaudhary0001
Copy link

This PR was tested for the UI hampering of the MM if the RHS is expanded fully.

But I am facing an issue here like if we click on the background area when the modal is opened and RHS is fully expanded, the RHS behind closes despite of that area being inactive.

Steps to reproduce:-

  1. Expand the RHS and open the modal.
  2. Click on the area behind the modal.

The RHS gets closed, which is not consistent for all the other plugins. Please have a look if we can handle this.
cc: @mickmister

@raghavaggarwal2308
Copy link
Contributor

@AayushChaudhary0001 The above issue seems to be a very rare edge case. Can you please create a separate issue for that?

@AayushChaudhary0001
Copy link

@raghavaggarwal2308 I have created a seperate issue for this(#260). Approving this PR for now.

@raghavaggarwal2308 raghavaggarwal2308 merged commit b9c79c7 into master Jul 22, 2024
4 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the fix_issue_218 branch July 22, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On expanding the RHS completely and opening the assigning modal hampers the UI
4 participants